Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2232273003: Update DataPipeConsumerDispatcher state when deserialized (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DataPipeConsumerDispatcher state when deserialized When transferring a data pipe consumer, it is possible that state update messages have already arrived when deserializing it. This CL makes DataPipeConsumerDispatcher handle such messages. Otherwise it may not notice the messages possibly forever. BUG=None Committed: https://crrev.com/d429ca27a689cbcfdb91b026a3f70695e8733f42 Cr-Commit-Position: refs/heads/master@{#411707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
yhirano
PTAL Sorry this CL doesn't have a test. I don't know how to write mojo ...
4 years, 4 months ago (2016-08-12 10:04:46 UTC) #7
yzshen1
LGTM (but please wait for John's opinion)
4 years, 4 months ago (2016-08-12 14:00:00 UTC) #8
jam
lgtm
4 years, 4 months ago (2016-08-12 17:50:15 UTC) #9
yhirano
Thanks!
4 years, 4 months ago (2016-08-12 17:51:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232273003/1
4 years, 4 months ago (2016-08-12 17:52:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 18:27:19 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d429ca27a689cbcfdb91b026a3f70695e8733f42 Cr-Commit-Position: refs/heads/master@{#411707}
4 years, 4 months ago (2016-08-12 18:28:44 UTC) #16
Ken Rockot(use gerrit already)
4 years, 4 months ago (2016-08-19 18:15:09 UTC) #18
Message was sent while issue was closed.
Just stumbled on this CL. Filed http://crbug.com/639363 for it.

Powered by Google App Engine
This is Rietveld 408576698