Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2232263002: Always give simple circular rrects a shot at being directly blurred on the GPU (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Always give simple circular rrects a shot at being directly blurred on the GPU I believe we want to do this but split it out of https://codereview.chromium.org/2201133002/ (Implement GPU occluded blur mask filter) b.c. it has its own perf implications and changes several GMs on its own. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232263002 Committed: https://skia.googlesource.com/skia/+/865606df97b7a52baefd75de624aaa7f912721b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 4 months ago (2016-08-11 14:33:37 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-08-11 14:35:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232263002/1
4 years, 4 months ago (2016-08-11 15:23:48 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 15:24:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/865606df97b7a52baefd75de624aaa7f912721b6

Powered by Google App Engine
This is Rietveld 408576698