Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2232243002: Rewrite canvas/philip/tests/2d.text.draw.text.metrics.html test (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite canvas/philip/tests/2d.text.draw.text.metrics.html test Currently this layout test canvas/philip/tests/2d.text.draw.text.metrics.html gets different results on linux platform comparing to all the other platforms. But when I open the test file directly on chrome, the result is exactly the same as the results on the other platform. The reason is that the content shell test runner has some flags enabled. This CL rewrite the test in a more reasonable way. BUG=277215 Committed: https://crrev.com/98591f5484bd77a1c261eda4379e323ed51e0ad1 Cr-Commit-Position: refs/heads/master@{#412571}

Patch Set 1 #

Patch Set 2 : update test expectations #

Patch Set 3 : add descrption on assert #

Patch Set 4 : added two more metrics #

Patch Set 5 : needs to be a async_test #

Messages

Total messages: 16 (11 generated)
xidachen
PTAL
4 years, 4 months ago (2016-08-11 14:07:18 UTC) #2
Justin Novosad
On 2016/08/11 14:07:18, xidachen wrote: > PTAL lgtm
4 years, 4 months ago (2016-08-11 19:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232243002/80001
4 years, 4 months ago (2016-08-17 17:21:20 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-17 17:25:12 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:27:20 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/98591f5484bd77a1c261eda4379e323ed51e0ad1
Cr-Commit-Position: refs/heads/master@{#412571}

Powered by Google App Engine
This is Rietveld 408576698