Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2232203005: [tools/perf] Enable v8 top_10_mobile benchmarks on mobile only (Closed)

Created:
4 years, 4 months ago by perezju
Modified:
4 years, 4 months ago
Reviewers:
nednguyen, rmcilroy
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Enable v8 top_10_mobile benchmarks on mobile only These benchmarks should not be running on non-mobile platforms. BUG=636790, 630854 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/0cdeb2d5f4785e9ccbaf4b6f0235021b0a436cf2 Cr-Commit-Position: refs/heads/master@{#411891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tools/perf/benchmarks/v8.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
perezju
If all looks good please feel free to land. (I'll be on a flight most ...
4 years, 4 months ago (2016-08-12 15:58:21 UTC) #3
rmcilroy
We were using this for some coverage of Ignition on desktop, but we will move ...
4 years, 4 months ago (2016-08-12 16:08:51 UTC) #6
perezju
On 2016/08/12 16:08:51, rmcilroy wrote: > We were using this for some coverage of Ignition ...
4 years, 4 months ago (2016-08-12 16:16:49 UTC) #7
rmcilroy
On 2016/08/12 16:16:49, perezju wrote: > On 2016/08/12 16:08:51, rmcilroy wrote: > > We were ...
4 years, 4 months ago (2016-08-12 16:19:54 UTC) #8
nednguyen
lgtm
4 years, 4 months ago (2016-08-12 20:29:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232203005/1
4 years, 4 months ago (2016-08-13 10:15:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 10:18:13 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 10:19:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cdeb2d5f4785e9ccbaf4b6f0235021b0a436cf2
Cr-Commit-Position: refs/heads/master@{#411891}

Powered by Google App Engine
This is Rietveld 408576698