Support additional user presubmit scripts named PRESUBMIT*.py.

Support additional user presubmit scripts named PRESUBMIT*.py.

This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2836bcf8102969bbbe56708d3dd6690bed271d5d

[Tobias Sargeant, 2016-08-11 14:27:25]

Description was changed from

==========
Support additional user presubmit scripts named PRESUBMIT*.py.

This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=
==========

to

==========
Support additional user presubmit scripts named PRESUBMIT*.py.

This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=
==========

[Tobias Sargeant, 2016-08-11 14:27:25]

tobiasjs@chromium.org changed reviewers:
+ dpranke@chromium.org

[Tobias Sargeant, 2016-08-11 14:29:38]

Hi Dirk,

WDYT of this? The aim is to allow something like PRESUBMIT-tobiasjs.py to exist
in my checkouts, and be run for my CLs to check for things specific to me (like
not leaving debug logging in :-P), without having to maintain a local patch to
the root PRESUBMIT.py.

[Dirk Pranke, 2016-08-12 23:28:25]

I think this isn't necessarily a bad idea, but we've managed to survive a long
time without it, so I'm not necessarily sure we should add it, either.

I'm wondering if you're solving a problem we should solve a different way, e.g.,
maybe your presubmit should just be checked in? Or maybe you should configure a
local git hook?

What are you doing in your presubmit?

[Tobias Sargeant, 2016-08-15 10:29:21]

On 2016/08/12 23:28:25, Dirk Pranke (slow) wrote:
> I think this isn't necessarily a bad idea, but we've managed to survive a long
> time without it, so I'm not necessarily sure we should add it, either.
> 
> I'm wondering if you're solving a problem we should solve a different way,
e.g.,
> maybe your presubmit should just be checked in? Or maybe you should configure
a
> local git hook?
> 
> What are you doing in your presubmit?

I'm personally grepping for logging that I've added, to make sure that I don't
do that (unless I meant to). Another use-case that came up was vetting todo
comments similarly.

[Dirk Pranke, 2016-08-15 23:44:20]

I guess this is fine, as I can't think of another way to easily do what you
want.

lgtm.

[Tobias Sargeant, 2016-08-16 11:05:13]

The CQ bit was checked by tobiasjs@chromium.org

[commit-bot: I haz the power, 2016-08-16 11:05:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 11:08:19]

Description was changed from

==========
Support additional user presubmit scripts named PRESUBMIT*.py.

This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=
==========

to

==========
Support additional user presubmit scripts named PRESUBMIT*.py.

This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2836bcf8102969...
==========

[commit-bot: I haz the power, 2016-08-16 11:08:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2836bcf8102969...