src/core/SkRRect.cpp - Issue 223213005: Fix SkRRect isEmpty assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkRRect.cpp

Issue 223213005: Fix SkRRect isEmpty assert (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkRRect.cpp

diff --git a/src/core/SkRRect.cpp b/src/core/SkRRect.cpp

index 082646c2a76594c4a33e47fa7b759ef3308634c1..27104c5fd548037cbcdaca7494b44867d45913fe 100644

--- a/src/core/SkRRect.cpp

+++ b/src/core/SkRRect.cpp

@@ -464,8 +464,7 @@ void SkRRect::validate() const {

SkASSERT(fRect.isEmpty());

SkASSERT(allRadiiZero && allRadiiSame && allCornersSquare);

robertphillips 2014/04/03 12:35:55 I don't think this is required at all. The precedi

- SkASSERT(0 == fRect.fLeft && 0 == fRect.fTop &&

- 0 == fRect.fRight && 0 == fRect.fBottom);

+ SkASSERT(fRect.fLeft == fRect.fRight && fRect.fTop == fRect.fBottom);

break;

case kRect_Type:

SkASSERT(!fRect.isEmpty());

« no previous file with comments | « no previous file | no next file » | no next file with comments »