Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 223213005: Fix SkRRect isEmpty assert (Closed)

Created:
6 years, 8 months ago by siglesias
Modified:
6 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix SkRRect isEmpty assert The rectangle could be empty but not all zeroes. BUG=skia:2379 Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>; Committed: http://code.google.com/p/skia/source/detail?r=14041

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove the conflicting ASSERT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/core/SkRRect.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
siglesias
6 years, 8 months ago (2014-04-03 08:10:23 UTC) #1
robertphillips
https://codereview.chromium.org/223213005/diff/1/src/core/SkRRect.cpp File src/core/SkRRect.cpp (right): https://codereview.chromium.org/223213005/diff/1/src/core/SkRRect.cpp#newcode466 src/core/SkRRect.cpp:466: I don't think this is required at all. The ...
6 years, 8 months ago (2014-04-03 12:35:55 UTC) #2
siglesias
On 2014/04/03 12:35:55, robertphillips wrote: > https://codereview.chromium.org/223213005/diff/1/src/core/SkRRect.cpp > File src/core/SkRRect.cpp (right): > > https://codereview.chromium.org/223213005/diff/1/src/core/SkRRect.cpp#newcode466 > ...
6 years, 8 months ago (2014-04-03 12:44:11 UTC) #3
siglesias
Remove the ASSERT
6 years, 8 months ago (2014-04-03 12:52:56 UTC) #4
robertphillips
lgtm
6 years, 8 months ago (2014-04-03 13:05:22 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-03 13:05:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/siglesias@igalia.com/223213005/20001
6 years, 8 months ago (2014-04-03 13:05:41 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:35:49 UTC) #8
Message was sent while issue was closed.
Change committed as 14041

Powered by Google App Engine
This is Rietveld 408576698