Mojo: Add an "overview" comment to mojo/public/cpp/system/core.h.

Mojo: Add an "overview" comment to mojo/public/cpp/system/core.h.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261390

[darin (slow to review), 2014-04-03 05:04:14]

LGTM

https://codereview.chromium.org/223213004/diff/1/mojo/public/cpp/system/core.h
File mojo/public/cpp/system/core.h (right):

https://codereview.chromium.org/223213004/diff/1/mojo/public/cpp/system/core....
mojo/public/cpp/system/core.h:27: // and its subclasses impose *no* extra
overhead over using |MojoHandlse|
typo: MojoHandlse

https://codereview.chromium.org/223213004/diff/1/mojo/public/cpp/system/core....
mojo/public/cpp/system/core.h:42: // along the lines of C++11's |unique_ptr|
(and exactly like Chromium's
nit: The parenthetical comment could bit-rot easily once we get to use C++11 in
Chromium ;-)

[viettrungluu, 2014-04-03 05:14:24]

Thanks.

On 2014/04/03 05:04:14, darin wrote:
> LGTM
> 
> https://codereview.chromium.org/223213004/diff/1/mojo/public/cpp/system/core.h
> File mojo/public/cpp/system/core.h (right):
> 
>
https://codereview.chromium.org/223213004/diff/1/mojo/public/cpp/system/core....
> mojo/public/cpp/system/core.h:27: // and its subclasses impose *no* extra
> overhead over using |MojoHandlse|
> typo: MojoHandlse

Oops! Fixed.

> 
>
https://codereview.chromium.org/223213004/diff/1/mojo/public/cpp/system/core....
> mojo/public/cpp/system/core.h:42: // along the lines of C++11's |unique_ptr|
> (and exactly like Chromium's
> nit: The parenthetical comment could bit-rot easily once we get to use C++11
in
> Chromium ;-)

I'm holding out hope that maybe once Chromium switches we'd also seriously
consider updating mojo/public/cpp to use C++11 too (and so I'd also have to
remove mentions of "emulation" and not being able to use STL containers of
move-only things).

(Though given the amount of C++03 code out there, I wonder if there won't be
people who want to stick to that. I'm just not going to think of the possibility
of having to maintaining a separate public/cpp03 directory along with a C++03
bindings generator....)

[viettrungluu, 2014-04-03 05:14:40]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-04-03 05:16:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/223213004/20001

[commit-bot: I haz the power, 2014-04-03 10:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 10:12:48]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[viettrungluu, 2014-04-03 14:19:41]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-04-03 14:20:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/223213004/20001

[viettrungluu, 2014-04-03 14:54:40]

Committed patchset #2 manually as r261390 (presubmit successful).