Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.h

Issue 2232093002: Removed parent data storage common to multiple CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unsigned from enum class Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSValue.h b/third_party/WebKit/Source/core/css/CSSValue.h
index b529e27399408cde71268859a6d983df3ebd4108..16814ad8ff211a347a344c7488d35325d5240944 100644
--- a/third_party/WebKit/Source/core/css/CSSValue.h
+++ b/third_party/WebKit/Source/core/css/CSSValue.h
@@ -186,10 +186,7 @@ protected:
ClassType getClassType() const { return static_cast<ClassType>(m_classType); }
explicit CSSValue(ClassType classType)
- : m_primitiveUnitType(0)
- , m_hasCachedCSSText(false)
- , m_valueListSeparator(SpaceSeparator)
- , m_classType(classType)
+ : m_classType(classType)
{
}
@@ -199,17 +196,6 @@ protected:
private:
void destroy();
-protected:
- // The bits in this section are only used by specific subclasses but kept here
- // to maximize struct packing.
-
- // CSSPrimitiveValue bits:
- unsigned m_primitiveUnitType : 7; // CSSPrimitiveValue::UnitType
- mutable unsigned m_hasCachedCSSText : 1;
-
- unsigned m_valueListSeparator : ValueListSeparatorBits;
esprehn 2016/08/11 05:42:35 this was done so these bits can pack with m_classT
-
-private:
unsigned m_classType : ClassTypeBits; // ClassType
};
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSValueList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698