Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 2232093002: Removed parent data storage common to multiple CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unsigned from enum class Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
index 64b5fe37b6e6e71330f99841b81503b55e02440c..41e30ce209e85b3822e09150aae0737feb0fb35d 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
@@ -208,6 +208,8 @@ static const AtomicString& valueName(CSSValueID valueID)
CSSPrimitiveValue::CSSPrimitiveValue(CSSValueID valueID)
: CSSValue(PrimitiveClass)
+ , m_primitiveUnitType(0)
+ , m_hasCachedCSSText(false)
{
init(UnitType::ValueID);
// TODO(sashab): Add a DCHECK_NE(valueID, CSSValueInvalid).
@@ -216,6 +218,8 @@ CSSPrimitiveValue::CSSPrimitiveValue(CSSValueID valueID)
CSSPrimitiveValue::CSSPrimitiveValue(double num, UnitType type)
: CSSValue(PrimitiveClass)
+ , m_primitiveUnitType(0)
+ , m_hasCachedCSSText(false)
{
init(type);
ASSERT(std::isfinite(num));
@@ -224,6 +228,8 @@ CSSPrimitiveValue::CSSPrimitiveValue(double num, UnitType type)
CSSPrimitiveValue::CSSPrimitiveValue(const Length& length, float zoom)
: CSSValue(PrimitiveClass)
+ , m_primitiveUnitType(0)
+ , m_hasCachedCSSText(false)
{
switch (length.type()) {
case Auto:

Powered by Google App Engine
This is Rietveld 408576698