[builtins] WIP: Array indexOf in TurboFan/Runtime

test/webkit/fast/js/array-prototype-properties-expected.txt

Index: test/webkit/fast/js/array-prototype-properties-expected.txt
diff --git a/test/webkit/fast/js/array-prototype-properties-expected.txt b/test/webkit/fast/js/array-prototype-properties-expected.txt
index 9e98e2608bd60ed7cca1382d41d788801a7d679b..6454417d699c5bc6a8e6875caf8da0585b6b0453 100644
--- a/test/webkit/fast/js/array-prototype-properties-expected.txt
+++ b/test/webkit/fast/js/array-prototype-properties-expected.txt
@@ -41,7 +41,7 @@ PASS Array.prototype.unshift.call(undefined, {}) threw exception TypeError: Arra
 PASS Array.prototype.every.call(undefined, toString) threw exception TypeError: Array.prototype.every called on null or undefined.
 PASS Array.prototype.forEach.call(undefined, toString) threw exception TypeError: Array.prototype.forEach called on null or undefined.
 PASS Array.prototype.some.call(undefined, toString) threw exception TypeError: Array.prototype.some called on null or undefined.
-PASS Array.prototype.indexOf.call(undefined, 0) threw exception TypeError: Array.prototype.indexOf called on null or undefined.
+PASS Array.prototype.indexOf.call(undefined, 0) threw exception TypeError: Cannot convert undefined or null to object.

[mattloring, 2016/08/16 16:57:32]

Alternatively, is there a way to modify the error generated by
ASSIGN_RETURN_FAILURE_ON_EXCEPTION?

[Jakob Kummerow, 2016/08/17 15:42:57]

See BUILTIN(ArrayConcat) in builtins-array.cc for a workaround.

 PASS Array.prototype.indlastIndexOfexOf.call(undefined, 0) threw exception TypeError: Cannot read property 'call' of undefined.

[mattloring, 2016/08/16 16:57:32]

While unrelated to this cl, this looks like a typo.

[Jakob Kummerow, 2016/08/17 15:42:57]

It does.
The test is correct insofar as an appropriate error message is both actually
thrown and expected to be thrown, but it clearly doesn't test what it intends to
test ;-)

 PASS Array.prototype.filter.call(undefined, toString) threw exception TypeError: Array.prototype.filter called on null or undefined.
 PASS Array.prototype.reduce.call(undefined, toString) threw exception TypeError: Array.prototype.reduce called on null or undefined.