Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: test/webkit/fast/js/array-prototype-properties-expected.txt

Issue 2232063002: [builtins] WIP: Array indexOf in TurboFan/Runtime (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update test to look for new error message Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/array-indexing-receiver.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/webkit/fast/js/array-prototype-properties-expected.txt
diff --git a/test/webkit/fast/js/array-prototype-properties-expected.txt b/test/webkit/fast/js/array-prototype-properties-expected.txt
index 9e98e2608bd60ed7cca1382d41d788801a7d679b..6454417d699c5bc6a8e6875caf8da0585b6b0453 100644
--- a/test/webkit/fast/js/array-prototype-properties-expected.txt
+++ b/test/webkit/fast/js/array-prototype-properties-expected.txt
@@ -41,7 +41,7 @@ PASS Array.prototype.unshift.call(undefined, {}) threw exception TypeError: Arra
PASS Array.prototype.every.call(undefined, toString) threw exception TypeError: Array.prototype.every called on null or undefined.
PASS Array.prototype.forEach.call(undefined, toString) threw exception TypeError: Array.prototype.forEach called on null or undefined.
PASS Array.prototype.some.call(undefined, toString) threw exception TypeError: Array.prototype.some called on null or undefined.
-PASS Array.prototype.indexOf.call(undefined, 0) threw exception TypeError: Array.prototype.indexOf called on null or undefined.
+PASS Array.prototype.indexOf.call(undefined, 0) threw exception TypeError: Cannot convert undefined or null to object.
mattloring 2016/08/16 16:57:32 Alternatively, is there a way to modify the error
Jakob Kummerow 2016/08/17 15:42:57 See BUILTIN(ArrayConcat) in builtins-array.cc for
PASS Array.prototype.indlastIndexOfexOf.call(undefined, 0) threw exception TypeError: Cannot read property 'call' of undefined.
mattloring 2016/08/16 16:57:32 While unrelated to this cl, this looks like a typo
Jakob Kummerow 2016/08/17 15:42:57 It does. The test is correct insofar as an appropr
PASS Array.prototype.filter.call(undefined, toString) threw exception TypeError: Array.prototype.filter called on null or undefined.
PASS Array.prototype.reduce.call(undefined, toString) threw exception TypeError: Array.prototype.reduce called on null or undefined.
« no previous file with comments | « test/mjsunit/array-indexing-receiver.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698