LayoutTests/fast/dom/custom/type-extension-undo-assert.html - Issue 22320009: Don't come undone when undoing the editing of a Custom Element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/type-extension-undo-assert.html

Issue 22320009: Don't come undone when undoing the editing of a Custom Element. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../js/resources/js-test-pre.js"></script>

	3 <div id="test" contenteditable><b is="x-a" style="font-style: italic;">Hello, wo rld!</b></div>
	Yuta Kitamura 2013/08/06 09:00:02 Correct me if I'm wrong, but this line creates a H Correct me if I'm wrong, but this line creates a HTML <b> (bold) element since the type "x-a" is not registered type? I don't fully understand how this HTML and execCommands ("bold", "undo" and "undo") could hit the setTypeExtension() function. Might be better to have comments clarifying the behavior of this test.
	4 <script>

	5 description('Tests that execCommand undo doesn\'t hork custom elements');
	yosin_UTC9 2013/08/06 09:06:07 s/hork/fork/ s/hork/fork/ Yuta Kitamura 2013/08/06 09:28:19 I guess this is a witty way of saying "to mess up" Show quoted text On 2013/08/06 09:06:07, Yoshifumi Inoue wrote: > s/hork/fork/ I guess this is a witty way of saying "to mess up" or something like that... http://en.wiktionary.org/wiki/hork
	6

	7 var test = document.getElementById('test');

	8 window.getSelection().selectAllChildren(test);

	9 document.execCommand('bold', false, null);

	10 document.execCommand('undo', false, null);

	11 document.execCommand('undo', false, null);

	12

	13 testPassed('did not crash');

	14 var successfullyParsed = true;

	15 </script>

	16 <script src="../../js/resources/js-test-post.js"></script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/custom/type-extension-undo-assert-expected.txt » ('j') | no next file with comments »