Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 22320006: Move gamepad reader code out of PepperHelperImpl in the effort to eliminate PepperHelperImpl. I'm a… (Closed)

Created:
7 years, 4 months ago by jam
Modified:
7 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move gamepad reader code out of PepperHelperImpl in the effort to eliminate PepperHelperImpl. I'm also making one instance per renderer instead of one per process for WebKit in RendererWebKitPlatformSupportImpl, and one per RenderView for Pepper. BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215897

Patch Set 1 #

Patch Set 2 : fix clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -28 lines) Patch
M content/renderer/pepper/pepper_helper_impl.h View 4 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_helper_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 4 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 4 months ago (2013-08-06 03:07:38 UTC) #1
scottmg
7 years, 4 months ago (2013-08-06 03:13:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698