Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Issue 2231993002: Add @visibleForTesting annotation to meta. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M pkg/meta/lib/meta.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-08-10 20:01:31 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2231993002/diff/1/pkg/meta/lib/meta.dart File pkg/meta/lib/meta.dart (right): https://codereview.chromium.org/2231993002/diff/1/pkg/meta/lib/meta.dart#newcode101 pkg/meta/lib/meta.dart:101: /// than otherwise necessary, to make code testable. ...
4 years, 4 months ago (2016-08-10 20:17:56 UTC) #2
scheglov
https://codereview.chromium.org/2231993002/diff/1/pkg/meta/lib/meta.dart File pkg/meta/lib/meta.dart (right): https://codereview.chromium.org/2231993002/diff/1/pkg/meta/lib/meta.dart#newcode101 pkg/meta/lib/meta.dart:101: /// than otherwise necessary, to make code testable. On ...
4 years, 4 months ago (2016-08-10 20:21:57 UTC) #3
scheglov
4 years, 4 months ago (2016-08-10 20:23:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5ade4b47f9e99389e08144ed6140d2fabfc57327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698