Expose Physical Web data

components/physical_web/data_source/physical_web_data_source.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PHYSICAL_WEB_DATA_SOURCE_PHYSICAL_WEB_DATA_SOURCE_H_
 #define COMPONENTS_PHYSICAL_WEB_DATA_SOURCE_PHYSICAL_WEB_DATA_SOURCE_H_
 
 #include <memory>
 
+#include physical_web_listener.h

[Olivier, 2016/08/22 07:45:09]

All include path must be full path starting from src.
Here
#include "components/physical_web/data_source/physical_web_listener.h"

We also tend to include the minimal amount of files in headers (and in source
file too).
You don't need the actual header here and can just forward declare the
PhysicalWebListener class.

[hayesjordan, 2016/08/22 17:06:21]

Done.

+
 namespace base {
 class ListValue;
 }
 
 // Helper class for accessing Physical Web metadata and controlling the scanner.
 class PhysicalWebDataSource {
  public:
   virtual ~PhysicalWebDataSource() {}
 
   // Starts scanning for Physical Web URLs. If |network_request_enabled| is
   // true, discovered URLs will be sent to a resolution service.
   virtual void StartDiscovery(bool network_request_enabled) = 0;
 
   // Stops scanning for Physical Web URLs and clears cached URL content.
   virtual void StopDiscovery() = 0;
 
   // Returns a list of resolved URLs and associated page metadata. If network
   // requests are disabled or if discovery is not active, the list will be
   // empty. The method can be called at any time to receive the current metadata
   // list.
   virtual std::unique_ptr<base::ListValue> GetMetadata() = 0;
 
   // Returns boolean |true| if network requests are disabled and there are one
   // or more discovered URLs that have not been sent to the resolution service.
   // The method can be called at any time to check for unresolved discoveries.
   // If discovery is inactive or network requests are enabled, it will always
   // return false.
   virtual bool HasUnresolvedDiscoveries() = 0;
+
+  // Register for changes to Physical Web URLs and associated page metadata.
+  virtual void RegisterListener(PhysicalWebListener* physical_web_listener) = 0;

[Olivier, 2016/08/22 07:45:09]

Please add UnregisterListener (or similar).

[hayesjordan, 2016/08/22 17:06:21]

Done.

 };
 
 #endif  // COMPONENTS_PHYSICAL_WEB_DATA_SOURCE_PHYSICAL_WEB_DATA_SOURCE_H_