Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2231963002: [turbofan] Avoid unnecessary minus zero checks for Float64->Tagged. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid unnecessary minus zero checks for Float64->Tagged. When we change representation from Float64 to Tagged and we know that the input value can never be -0, we don't need to bother introducing the check for -0 during effect/control linearization. R=jarin@chromium.org Committed: https://crrev.com/3cc4e25cbf0909e776906bf39f4c5c5174220f3d Cr-Commit-Position: refs/heads/master@{#38568}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -60 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 2 chunks +23 lines, -19 lines 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 4 chunks +27 lines, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 6 chunks +39 lines, -33 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (17 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-10 18:08:46 UTC) #1
Benedikt Meurer
Hey Jaro, Here's another low hanging fruit that'll hopefully reduce compilation overhead and code size ...
4 years, 4 months ago (2016-08-10 18:10:36 UTC) #4
Jarin
lgtm
4 years, 4 months ago (2016-08-11 05:29:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231963002/20001
4 years, 4 months ago (2016-08-11 05:41:43 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 05:44:53 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 05:45:09 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cc4e25cbf0909e776906bf39f4c5c5174220f3d
Cr-Commit-Position: refs/heads/master@{#38568}

Powered by Google App Engine
This is Rietveld 408576698