third_party/WebKit/Source/core/css/CSSValue.cpp - Issue 2231953003: Added ASSERT_SIZE macro for checking size of size-sensitive classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.cpp

Issue 2231953003: Added ASSERT_SIZE macro for checking size of size-sensitive classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSValue.cpp b/third_party/WebKit/Source/core/css/CSSValue.cpp

index d0a7b501761b865634e99fc9017758b348eef812..a77ed4ac30f846d3751dc192666a37251ea66f05 100644

--- a/third_party/WebKit/Source/core/css/CSSValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSValue.cpp

@@ -62,14 +62,11 @@

#include "core/css/CSSValueList.h"

#include "core/css/CSSValuePair.h"

#include "core/css/CSSVariableReferenceValue.h"

+#include "wtf/SizeAssertions.h"

namespace blink {

-struct SameSizeAsCSSValue : public GarbageCollectedFinalized<SameSizeAsCSSValue> {

- uint32_t bitfields;

-};

-static_assert(sizeof(CSSValue) <= sizeof(SameSizeAsCSSValue), "CSSValue should stay small");

+ASSERT_SIZE(CSSValue, 4, 8);

bool CSSValue::isImplicitInitialValue() const

{

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/SizeAssertions.h » ('j') | third_party/WebKit/Source/wtf/SizeAssertions.h » ('J')