Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSValue.cpp

Issue 2231953003: Added ASSERT_SIZE macro for checking size of size-sensitive classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Andreas Kling (kling@webkit.org) 2 * Copyright (C) 2011 Andreas Kling (kling@webkit.org)
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 #include "core/css/CSSReflectValue.h" 55 #include "core/css/CSSReflectValue.h"
56 #include "core/css/CSSShadowValue.h" 56 #include "core/css/CSSShadowValue.h"
57 #include "core/css/CSSStringValue.h" 57 #include "core/css/CSSStringValue.h"
58 #include "core/css/CSSTimingFunctionValue.h" 58 #include "core/css/CSSTimingFunctionValue.h"
59 #include "core/css/CSSURIValue.h" 59 #include "core/css/CSSURIValue.h"
60 #include "core/css/CSSUnicodeRangeValue.h" 60 #include "core/css/CSSUnicodeRangeValue.h"
61 #include "core/css/CSSUnsetValue.h" 61 #include "core/css/CSSUnsetValue.h"
62 #include "core/css/CSSValueList.h" 62 #include "core/css/CSSValueList.h"
63 #include "core/css/CSSValuePair.h" 63 #include "core/css/CSSValuePair.h"
64 #include "core/css/CSSVariableReferenceValue.h" 64 #include "core/css/CSSVariableReferenceValue.h"
65 #include "wtf/SizeAssertions.h"
65 66
66 namespace blink { 67 namespace blink {
67 68
68 struct SameSizeAsCSSValue : public GarbageCollectedFinalized<SameSizeAsCSSValue> { 69 struct SameSizeAsCSSValue : public GarbageCollectedFinalized<SameSizeAsCSSValue> {
69 uint32_t bitfields; 70 uint32_t bitfields;
70 }; 71 };
71 72 ASSERT_SIZE(CSSValue, SameSizeAsCSSValue);
72 static_assert(sizeof(CSSValue) <= sizeof(SameSizeAsCSSValue), "CSSValue should s tay small");
73 73
74 bool CSSValue::isImplicitInitialValue() const 74 bool CSSValue::isImplicitInitialValue() const
75 { 75 {
76 return m_classType == InitialClass && toCSSInitialValue(this)->isImplicit(); 76 return m_classType == InitialClass && toCSSInitialValue(this)->isImplicit();
77 } 77 }
78 78
79 bool CSSValue::hasFailedOrCanceledSubresources() const 79 bool CSSValue::hasFailedOrCanceledSubresources() const
80 { 80 {
81 if (isValueList()) 81 if (isValueList())
82 return toCSSValueList(this)->hasFailedOrCanceledSubresources(); 82 return toCSSValueList(this)->hasFailedOrCanceledSubresources();
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 toCSSCustomPropertyDeclaration(this)->traceAfterDispatch(visitor); 535 toCSSCustomPropertyDeclaration(this)->traceAfterDispatch(visitor);
536 return; 536 return;
537 case PendingSubstitutionValueClass: 537 case PendingSubstitutionValueClass:
538 toCSSPendingSubstitutionValue(this)->traceAfterDispatch(visitor); 538 toCSSPendingSubstitutionValue(this)->traceAfterDispatch(visitor);
539 return; 539 return;
540 } 540 }
541 ASSERT_NOT_REACHED(); 541 ASSERT_NOT_REACHED();
542 } 542 }
543 543
544 } // namespace blink 544 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698