Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2231953002: Bot_update recipe output: Add 'Try Rebasing' to patch failure output (Closed)

Created:
4 years, 4 months ago by Ryan Tseng
Modified:
4 years, 4 months ago
Reviewers:
dnj, tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bot_update recipe output: Add 'Try Rebasing' to patch failure output I still see confusion around patch failures. This should clearify things. BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d2c82a25e81bf39b8a9e3da1350374e5c00d0594

Patch Set 1 #

Patch Set 2 : Train #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Ryan Tseng
Train
4 years, 4 months ago (2016-08-10 18:10:20 UTC) #3
Ryan Tseng
I don't know if this is a silly patch or not, but I still see ...
4 years, 4 months ago (2016-08-10 18:11:59 UTC) #7
tandrii(chromium)
lgtm This is actually really really good!
4 years, 4 months ago (2016-08-10 19:16:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231953002/20001
4 years, 4 months ago (2016-08-10 19:18:10 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:21:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d2c82a25e81bf3...

Powered by Google App Engine
This is Rietveld 408576698