Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2231943002: Use SVGs CIPD package and use SVG as a DM source (Closed)

Created:
4 years, 4 months ago by rmistry
Modified:
4 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SVGs CIPD package and use SVG as a DM source. Currently only turned on for one bot. May turn it on for more after more conversations. BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002 Committed: https://skia.googlesource.com/skia/+/bcba19dd0232f9ec75dae8f5987e0d15bbf93c41

Patch Set 1 : Initial upload #

Patch Set 2 : Hack in got_revision #

Patch Set 3 : Fix #

Patch Set 4 : Add svg for this builder #

Patch Set 5 : Update rev #

Patch Set 6 : Cleanup #

Patch Set 7 : Remove test code #

Patch Set 8 : Tests failing #

Patch Set 9 : Update #

Patch Set 10 : Add test case for coverage #

Patch Set 11 : Fix test #

Total comments: 4

Patch Set 12 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1708 lines, -120 lines) Patch
M infra/bots/recipe_modules/flavor/android_flavor.py View 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipe_modules/flavor/api.py View 1 2 3 4 5 6 7 3 chunks +28 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/flavor/default_flavor.py View 3 chunks +7 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/flavor/ios_flavor.py View 2 chunks +2 lines, -1 line 0 comments Download
M infra/bots/recipe_modules/vars/api.py View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.py View 1 2 3 4 5 6 7 8 9 10 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Release.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Release.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Release.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +101 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 1 2 3 4 5 6 7 8 9 10 11 18 chunks +108 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-AndroidOne-GPU-Mali400MP2-Arm7-Release.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +30 lines, -5 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +101 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/adb_in_path.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skimage.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skps.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/download_and_push_svgs.json View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +84 lines, -49 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +20 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +35 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/missing_SVG_VERSION_device.json View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +84 lines, -49 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +10 lines, -1 line 0 comments Download
A + infra/bots/recipes/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 2 3 4 5 6 7 8 9 10 11 13 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
rmistry
4 years, 4 months ago (2016-08-11 15:17:19 UTC) #9
borenet
https://codereview.chromium.org/2231943002/diff/200001/infra/bots/recipes/swarm_test.py File infra/bots/recipes/swarm_test.py (right): https://codereview.chromium.org/2231943002/diff/200001/infra/bots/recipes/swarm_test.py#newcode435 infra/bots/recipes/swarm_test.py:435: '--svgs', api.flavor.device_dirs.svg_dir, Only supply this for the bots which ...
4 years, 4 months ago (2016-08-11 16:20:53 UTC) #10
rmistry
I initially left it in because all bots are going to be turned on very ...
4 years, 4 months ago (2016-08-11 16:41:48 UTC) #11
borenet
LGTM. I just want to make sure we get some idea of the overhead of ...
4 years, 4 months ago (2016-08-11 16:58:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231943002/220001
4 years, 4 months ago (2016-08-11 19:35:37 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 19:37:02 UTC) #20
Message was sent while issue was closed. 
Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/bcba19dd0232f9ec75dae8f5987e0d15bbf93c41

Powered by Google App Engine
This is Rietveld 408576698