Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Side by Side Diff: src/objects-printer.cc

Issue 223193005: Get rid of the TRANSITION PropertyType and consistently use CanHoldValue(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use number_ for LastAdded in transition results. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 PrintF(out, " (constant)\n"); 264 PrintF(out, " (constant)\n");
265 break; 265 break;
266 case CALLBACKS: 266 case CALLBACKS:
267 descs->GetCallbacksObject(i)->ShortPrint(out); 267 descs->GetCallbacksObject(i)->ShortPrint(out);
268 PrintF(out, " (callback)\n"); 268 PrintF(out, " (callback)\n");
269 break; 269 break;
270 case NORMAL: // only in slow mode 270 case NORMAL: // only in slow mode
271 case HANDLER: // only in lookup results, not in descriptors 271 case HANDLER: // only in lookup results, not in descriptors
272 case INTERCEPTOR: // only in lookup results, not in descriptors 272 case INTERCEPTOR: // only in lookup results, not in descriptors
273 // There are no transitions in the descriptor array. 273 // There are no transitions in the descriptor array.
274 case TRANSITION:
275 case NONEXISTENT: 274 case NONEXISTENT:
276 UNREACHABLE(); 275 UNREACHABLE();
277 break; 276 break;
278 } 277 }
279 } 278 }
280 } else { 279 } else {
281 property_dictionary()->Print(out); 280 property_dictionary()->Print(out);
282 } 281 }
283 } 282 }
284 283
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 case CONSTANT: 420 case CONSTANT:
422 PrintF(out, " (transition to constant)\n"); 421 PrintF(out, " (transition to constant)\n");
423 break; 422 break;
424 case CALLBACKS: 423 case CALLBACKS:
425 PrintF(out, " (transition to callback)\n"); 424 PrintF(out, " (transition to callback)\n");
426 break; 425 break;
427 // Values below are never in the target descriptor array. 426 // Values below are never in the target descriptor array.
428 case NORMAL: 427 case NORMAL:
429 case HANDLER: 428 case HANDLER:
430 case INTERCEPTOR: 429 case INTERCEPTOR:
431 case TRANSITION:
432 case NONEXISTENT: 430 case NONEXISTENT:
433 UNREACHABLE(); 431 UNREACHABLE();
434 break; 432 break;
435 } 433 }
436 } 434 }
437 } 435 }
438 } 436 }
439 437
440 438
441 void JSObject::JSObjectPrint(FILE* out) { 439 void JSObject::JSObjectPrint(FILE* out) {
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
1216 case CONSTANT: 1214 case CONSTANT:
1217 PrintF(out, " (transition to constant)\n"); 1215 PrintF(out, " (transition to constant)\n");
1218 break; 1216 break;
1219 case CALLBACKS: 1217 case CALLBACKS:
1220 PrintF(out, " (transition to callback)\n"); 1218 PrintF(out, " (transition to callback)\n");
1221 break; 1219 break;
1222 // Values below are never in the target descriptor array. 1220 // Values below are never in the target descriptor array.
1223 case NORMAL: 1221 case NORMAL:
1224 case HANDLER: 1222 case HANDLER:
1225 case INTERCEPTOR: 1223 case INTERCEPTOR:
1226 case TRANSITION:
1227 case NONEXISTENT: 1224 case NONEXISTENT:
1228 UNREACHABLE(); 1225 UNREACHABLE();
1229 break; 1226 break;
1230 } 1227 }
1231 } 1228 }
1232 PrintF(out, "\n"); 1229 PrintF(out, "\n");
1233 } 1230 }
1234 1231
1235 1232
1236 #endif // OBJECT_PRINT 1233 #endif // OBJECT_PRINT
1237 1234
1238 1235
1239 } } // namespace v8::internal 1236 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698