Chromium Code Reviews
Description[Media Router WebUI] Append new sinks to the end of the list.
Currently, when the sink list is updated in the WebUI, we just replace |sinksToShow_| in the container. This sometimes causes re-sorting and sinks suddenly appear in a different place. This can result in accidental casting to the wrong sink.
This change appends new sinks to the end of the sink list. A user who has incrementally discovered sinks will see the dialog grow vertically as new sinks are appended at the bottom of the list.
Also updated variable naming to make it more easily readable.
BUG=634365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2221933003
Cr-Commit-Position: refs/heads/master@{#410585}
(cherry picked from commit e23faebb13dc082e283a8e53d460a7cb8625aabd)
Committed: https://chromium.googlesource.com/chromium/src/+/e27d22a53409415b174df1b775ae5de195b67b9f
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||