Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2231893002: [Media Router WebUI] Append new sinks to the end of the list. (Closed)

Created:
4 years, 4 months ago by apacible
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Append new sinks to the end of the list. Currently, when the sink list is updated in the WebUI, we just replace |sinksToShow_| in the container. This sometimes causes re-sorting and sinks suddenly appear in a different place. This can result in accidental casting to the wrong sink. This change appends new sinks to the end of the sink list. A user who has incrementally discovered sinks will see the dialog grow vertically as new sinks are appended at the bottom of the list. Also updated variable naming to make it more easily readable. BUG=634365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2221933003 Cr-Commit-Position: refs/heads/master@{#410585} (cherry picked from commit e23faebb13dc082e283a8e53d460a7cb8625aabd) Committed: https://chromium.googlesource.com/chromium/src/+/e27d22a53409415b174df1b775ae5de195b67b9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -4 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 3 chunks +24 lines, -4 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 4 months ago (2016-08-10 16:51:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e27d22a53409415b174df1b775ae5de195b67b9f.

Powered by Google App Engine
This is Rietveld 408576698