third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html - Issue 2231873002: Added budget_service.mojom

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html

Issue 2231873002: Added budget_service.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@budget_api

Patch Set: Split tests, cleaned up constructor, and nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js ('k') | third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html » ('j') | third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Budget API: Makes basic getCost and getBudget calls.</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="/js-test-resources/mojo-helpers.js"></script>

	8 <script src="budget-service-mock.js"></script>

	9 </head>

	10 <body>

	11 <script>

	12 if (!window.mojo)

	13 debug('This test can not run without mojo');

	14

	15 promise_test(function() {

	16 return budgetServiceMock.then(mock => {

	17 assert_own_property(Navigator.prototype, 'budget');

	18 return navigator.budget.getBudget();

	19 }).then(budget => {

	20 assert_equals(budget.length, 1);

	21 assert_equals(budget[0].budgetAt, TEST_BUDGET_AT);

	22 assert_equals(budget[0].time, TEST_BUDGET_TIME);
	Peter Beverloo 2016/08/23 09:46:39 nit: please consistently indent your code (either nit: please consistently indent your code (either two or four spaces) harkness 2016/08/23 10:06:17 Sorry about that, for some reason the auto-indenti Show quoted text On 2016/08/23 09:46:39, Peter Beverloo wrote: > nit: please consistently indent your code (either two or four spaces) Sorry about that, for some reason the auto-indenting isn't working well for Javascript in HTML. Fixed now.
	23 });

	24 }, 'BudgetService mock for GetBudget should return correct results.');
	Peter Beverloo 2016/08/23 09:46:38 Here and elsewhere: you make it sound like you're Here and elsewhere: you make it sound like you're testing the mock, but you're really testing the code path within Blink. In addition, this description doesn't match the test. harkness 2016/08/23 10:06:17 Done. Show quoted text On 2016/08/23 09:46:38, Peter Beverloo wrote: > Here and elsewhere: you make it sound like you're testing the mock, but you're > really testing the code path within Blink. In addition, this description doesn't > match the test. Done.
	25 </script>

	26 </body>

	27 </html>

OLD	NEW