third_party/WebKit/Source/modules/budget/BudgetState.cpp - Issue 2231873002: Added budget_service.mojom

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/budget/BudgetState.cpp

Issue 2231873002: Added budget_service.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@budget_api

Patch Set: Converted BudgetChunk dictionary to BudgetState interface and other code review updates Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "modules/budget/BudgetState.h"

	6

5 namespace blink {	7 namespace blink {

6 void genThing();

7	8

8 class GenClass {	9 BudgetState::BudgetState()
	Peter Beverloo 2016/08/22 17:57:55 This would leave m_budgetAt and m_time uninitializ This would leave m_budgetAt and m_time uninitialized, which could yield unexpected behaviour. Please initialize them. Also, why not just define both constructors out-of-line (thus in the .cc file)? harkness 2016/08/23 09:38:18 Done. Show quoted text On 2016/08/22 17:57:55, Peter Beverloo wrote: > This would leave m_budgetAt and m_time uninitialized, which could yield > unexpected behaviour. Please initialize them. > > Also, why not just define both constructors out-of-line (thus in the .cc file)? Done.
9 virtual void genMethod() {}	10 {

10 };

11 }	11 }

	12

	13 } // namespace blink

OLD	NEW