Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: third_party/WebKit/Source/modules/budget/BudgetService.cpp

Issue 2231873002: Added budget_service.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@budget_api
Patch Set: Converted BudgetChunk dictionary to BudgetState interface and other code review updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/budget/BudgetService.h" 5 #include "modules/budget/BudgetService.h"
6 6
7 #include "bindings/core/v8/ScriptPromise.h" 7 #include "bindings/core/v8/ScriptPromise.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "bindings/core/v8/ScriptState.h" 9 #include "bindings/core/v8/ScriptState.h"
10 #include "core/dom/DOMException.h" 10 #include "core/dom/DOMException.h"
11 #include "core/dom/ExceptionCode.h" 11 #include "core/dom/ExceptionCode.h"
12 #include "modules/budget/BudgetState.h"
13 #include "public/platform/InterfaceProvider.h"
14 #include "public/platform/Platform.h"
15 #include "public/platform/modules/budget_service/budget_service.mojom-blink.h"
12 16
13 namespace blink { 17 namespace blink {
14 18
15 BudgetService::BudgetService() {} 19 BudgetService::BudgetService()
20 {
21 Platform::current()->interfaceProvider()->getInterface(mojo::GetProxy(&m_ser vice));
22 DCHECK(m_service);
Peter Beverloo 2016/08/22 17:57:55 I don't think this DCHECK is valid— when getting t
harkness 2016/08/23 09:38:18 Done. Added the check to getCost and getBudget ins
23 }
16 24
17 ScriptPromise BudgetService::getCost(ScriptState* scriptState, const AtomicStrin g& actionType) 25 BudgetService::~BudgetService()
18 { 26 {
19 // TODO(harkness): Trigger the cost calculation. 27 }
20 return ScriptPromise::rejectWithDOMException(scriptState, DOMException::crea te(NotSupportedError, "Not yet implemented")); 28
29 ScriptPromise BudgetService::getCost(ScriptState* scriptState, const AtomicStrin g& /* actionType */)
30 {
31 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
32 ScriptPromise promise = resolver->promise();
33
34 // TODO(harkness): Map the actionType to BudgetOperationType.
35 // Get the cost for the action from the browser BudgetService.
36 mojom::blink::BudgetOperationType type = mojom::blink::BudgetOperationType:: SILENT_PUSH;
37 m_service->GetCost(type, convertToBaseCallback(WTF::bind(&BudgetService::got Cost, wrapPersistent(this), wrapPersistent(resolver))));
38 return promise;
39 }
40
41 void BudgetService::gotCost(ScriptPromiseResolver* resolver, double cost) const
42 {
43 resolver->resolve(cost);
21 } 44 }
22 45
23 ScriptPromise BudgetService::getBudget(ScriptState* scriptState) 46 ScriptPromise BudgetService::getBudget(ScriptState* scriptState)
24 { 47 {
25 // TODO(harkness): Trigger the budget calculation. 48 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
26 return ScriptPromise::rejectWithDOMException(scriptState, DOMException::crea te(NotSupportedError, "Not yet implemented")); 49 ScriptPromise promise = resolver->promise();
50
51 // Get the budget from the browser BudgetService.
52 RefPtr<SecurityOrigin> origin(scriptState->getExecutionContext()->getSecurit yOrigin());
53 m_service->GetBudget(origin, convertToBaseCallback(WTF::bind(&BudgetService: :gotBudget, wrapPersistent(this), wrapPersistent(resolver))));
54 return promise;
55 }
56
57 void BudgetService::gotBudget(ScriptPromiseResolver* resolver, const mojo::WTFAr ray<mojom::blink::BudgetStatePtr> expectations) const
58 {
59 // Copy the chunks into the budget array.
60 HeapVector<Member<BudgetState>> budget(expectations.size());
61 for (uint i = 0; i < expectations.size(); i++)
Peter Beverloo 2016/08/22 17:57:55 nit: we usually use size_t for this, which is also
harkness 2016/08/23 09:38:18 Done.
62 budget[i] = new BudgetState(expectations[i]->budget_at, expectations[i]- >time);
63
64 resolver->resolve(budget);
27 } 65 }
28 66
29 } // namespace blink 67 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698