third_party/WebKit/LayoutTests/http/tests/budget/success-query-path.html - Issue 2231873002: Added budget_service.mojom

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/budget/success-query-path.html

Issue 2231873002: Added budget_service.mojom (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@budget_api

Patch Set: Converted BudgetChunk dictionary to BudgetState interface and other code review updates Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js ('K') | « third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js ('k') | third_party/WebKit/Source/modules/budget/BudgetChunk.idl » ('j') | third_party/WebKit/Source/modules/budget/BudgetService.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Budget API: Makes basic getCost and getBudget calls.</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="/js-test-resources/mojo-helpers.js"></script>

	8 <script src="budget-service-mock.js"></script>

	9 </head>

	10 <body>

	11 <script>

	12 if (!window.mojo)

	13 debug('This test can not run without mojo');

	14

	15 promise_test(function() {

	16 return budgetServiceMock.then(mock => {

	17 assert_own_property(Navigator.prototype, 'budget');

	18 return navigator.budget.getCost("silent-push");

	19 }).then(cost => {

	20 assert_equals(cost, TEST_BUDGET_COST);

	21 });

	22 }, 'BudgetService mock for GetCost should return correct results.');
	Peter Beverloo 2016/08/22 17:57:55 nit: I would split this up to one test per functio nit: I would split this up to one test per function. For instance, for getCost() you'd want to test the behaviour of calling it with an unrecognized argument. It would also act as an additional guard against depending on test execution order. harkness 2016/08/23 09:38:18 Done. We no longer have success-query-path, instea Show quoted text On 2016/08/22 17:57:55, Peter Beverloo wrote: > nit: I would split this up to one test per function. For instance, for getCost() > you'd want to test the behaviour of calling it with an unrecognized argument. It > would also act as an additional guard against depending on test execution order. Done. We no longer have success-query-path, instead we have get-cost and get-budget.
	23

	24 promise_test(function() {

	25 return budgetServiceMock.then(mock => {

	26 assert_own_property(Navigator.prototype, 'budget');

	27 return navigator.budget.getBudget();

	28 }).then(budget => {

	29 assert_equals(budget.length, 1);

	30 assert_equals(budget[0].budgetAt, TEST_BUDGET_AT);

	31 assert_equals(budget[0].time, TEST_BUDGET_TIME);

	32 });

	33 }, 'BudgetService mock for GetBudget should return correct results.');

	34 </script>

	35 </body>

	36 </html>

OLD	NEW