Take Murmur2 hash of untransformed icon when creating WebAPK part 1

chrome/browser/android/webapk/webapk_installer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include <jni.h>
 #include <memory>
 #include <string>
 
@@ skipping 18 matching lines @@
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "url/gurl.h"
 
 namespace {
 
 const base::FilePath::CharType kTestDataDir[] =
     FILE_PATH_LITERAL("chrome/test/data");
 
 // URL of mock WebAPK server.
-const std::string kServerUrl = "/webapkserver";
+const char* kServerUrl = "/webapkserver";
+
+// Icon URL from Web Manifest. We use a random file in the test data directory.
+// Since WebApkInstaller does not try to decode the file as an image it is OK
+// that the file is not an image.
+const char* kIconUrl = "/simple.html";
 
 // URL of file to download from the WebAPK server. We use a random file in the
 // test data directory.
-const std::string kDownloadUrl = "/simple.html";
+const char* kDownloadUrl = "/simple.html";
 
 // The package name of the downloaded WebAPK.
-const std::string kDownloadedWebApkPackageName = "party.unicode";
+const char* kDownloadedWebApkPackageName = "party.unicode";
 
 // WebApkInstaller subclass where
 // WebApkInstaller::StartDownloadedWebApkInstall() is stubbed out.
 class TestWebApkInstaller : public WebApkInstaller {
  public:
   TestWebApkInstaller(const ShortcutInfo& shortcut_info,
                       const SkBitmap& shortcut_icon)
       : WebApkInstaller(shortcut_info, shortcut_icon) {}
 
   bool StartDownloadedWebApkInstall(
       JNIEnv* env,
       const base::android::ScopedJavaLocalRef<jstring>& file_path,
       const base::android::ScopedJavaLocalRef<jstring>& package_name) override {
     return true;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestWebApkInstaller);
 };
 
 // Runs the WebApkInstaller installation process and blocks till done.
 class WebApkInstallerRunner {
  public:
-  WebApkInstallerRunner()
+  explicit WebApkInstallerRunner(const GURL& icon_url)
       : url_request_context_getter_(new net::TestURLRequestContextGetter(
-            base::ThreadTaskRunnerHandle::Get())) {}
+            base::ThreadTaskRunnerHandle::Get())),
+        icon_url_(icon_url) {}
   ~WebApkInstallerRunner() {}
 
   void Run() {
     ShortcutInfo info(GURL::EmptyGURL());
+    info.icon_url = icon_url_;
 
     // WebApkInstaller owns itself.
     WebApkInstaller* installer = new TestWebApkInstaller(info, SkBitmap());
 
     installer->SetTimeoutMs(100);
+
+    base::RunLoop run_loop;
+    on_completed_callback_ = run_loop.QuitClosure();
     installer->InstallAsyncWithURLRequestContextGetter(
         url_request_context_getter_.get(),
         base::Bind(&WebApkInstallerRunner::OnCompleted,
                    base::Unretained(this)));
-
-    base::RunLoop run_loop;
-    on_completed_callback_ = run_loop.QuitClosure();
     run_loop.Run();
   }
 
   bool success() { return success_; }
 
  private:
   void OnCompleted(bool success) {
     success_ = success;
     on_completed_callback_.Run();
   }
 
   scoped_refptr<net::TestURLRequestContextGetter>
       url_request_context_getter_;
 
+  // The Web Manifest's icon URL.
+  const GURL icon_url_;
+
   // Called after the installation process has succeeded or failed.
   base::Closure on_completed_callback_;
 
   // Whether the installation process succeeded.
   bool success_;
 
   DISALLOW_COPY_AND_ASSIGN(WebApkInstallerRunner);
 };
 
 // Builds a webapk::WebApkResponse with |download_url| as the WebAPK download
@@ skipping 28 matching lines @@
   void SetUp() override {
     test_server_.AddDefaultHandlers(base::FilePath(kTestDataDir));
     test_server_.RegisterRequestHandler(
         base::Bind(&WebApkInstallerTest::HandleCreateWebApkRequest,
                    base::Unretained(this)));
     ASSERT_TRUE(test_server_.Start());
 
     SetDefaults();
   }
 
+  // Sets the Web Manifest's icon URL.
+  void SetIconUrl(const GURL& icon_url) {
+      icon_url_ = icon_url;

[Robert Sesek, 2016/08/16 19:55:57]

nit: over-indented

+  }
+
   // Sets the URL to send the webapk::CreateWebApkRequest to. WebApkInstaller
   // should fail if the URL is not |kServerUrl|.
   void SetWebApkServerUrl(const GURL& server_url) {
     base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
         switches::kWebApkServerUrl, server_url.spec());
   }
 
   // Sets the function that should be used to build the response to the
   // WebAPK creation request.
   void SetWebApkResponseBuilder(const WebApkResponseBuilder& builder) {
     webapk_response_builder_ = builder;
   }
 
+  std::unique_ptr<WebApkInstallerRunner> CreateWebApkInstallerRunner() {
+    return std::unique_ptr<WebApkInstallerRunner>(
+        new WebApkInstallerRunner(icon_url_));
+  }
+
   net::test_server::EmbeddedTestServer* test_server() { return &test_server_; }
 
  private:
   // Sets default configuration for running WebApkInstaller.
   void SetDefaults() {
+    GURL icon_url = test_server_.GetURL(kIconUrl);
+    SetIconUrl(icon_url);
     GURL server_url = test_server_.GetURL(kServerUrl);
     SetWebApkServerUrl(server_url);
     GURL download_url = test_server_.GetURL(kDownloadUrl);
     SetWebApkResponseBuilder(
         base::Bind(&BuildValidWebApkResponse, download_url));
   }
 
   std::unique_ptr<net::test_server::HttpResponse> HandleCreateWebApkRequest(
       const net::test_server::HttpRequest& request) {
     return (request.relative_url == kServerUrl)
                ? webapk_response_builder_.Run()
                : std::unique_ptr<net::test_server::HttpResponse>();
   }
 
   content::TestBrowserThreadBundle thread_bundle_;
   net::EmbeddedTestServer test_server_;
 
+  // Web Manifest's icon URL.
+  GURL icon_url_;
+
   // Builds response to the WebAPK creation request.
   WebApkResponseBuilder webapk_response_builder_;
 
   DISALLOW_COPY_AND_ASSIGN(WebApkInstallerTest);
 };
 
 // Test installation succeeding.
 TEST_F(WebApkInstallerTest, Success) {
-  WebApkInstallerRunner runner;
-  runner.Run();
-  EXPECT_TRUE(runner.success());
+  std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
+  runner->Run();
+  EXPECT_TRUE(runner->success());
+}
+
+// Test that installation fails if fetching the bitmap at the icon URL times
+// out. In a perfect world the fetch would never time out because the bitmap at
+// the icon URL should be in the HTTP cache.
+TEST_F(WebApkInstallerTest, IconUrlDownloadTimesOut) {
+  GURL icon_url = test_server()->GetURL("/slow?1000");
+  SetIconUrl(icon_url);
+
+  std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
+  runner->Run();
+  EXPECT_FALSE(runner->success());
 }
 
 // Test that installation fails if the WebAPK creation request times out.
 TEST_F(WebApkInstallerTest, CreateWebApkRequestTimesOut) {
   GURL server_url = test_server()->GetURL("/slow?1000");
   SetWebApkServerUrl(server_url);
 
-  WebApkInstallerRunner runner;
-  runner.Run();
-  EXPECT_FALSE(runner.success());
+  std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
+  runner->Run();
+  EXPECT_FALSE(runner->success());
 }
 
 // Test that installation fails if the WebAPK download times out.
 TEST_F(WebApkInstallerTest, WebApkDownloadTimesOut) {
   GURL download_url = test_server()->GetURL("/slow?1000");
   SetWebApkResponseBuilder(base::Bind(&BuildValidWebApkResponse, download_url));
 
-  WebApkInstallerRunner runner;
-  runner.Run();
-  EXPECT_FALSE(runner.success());
+  std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
+  runner->Run();
+  EXPECT_FALSE(runner->success());
 }
 
 // Test that installation fails if the WebAPK download fails.
 TEST_F(WebApkInstallerTest, WebApkDownloadFails) {
   GURL download_url = test_server()->GetURL("/nocontent");
   SetWebApkResponseBuilder(base::Bind(&BuildValidWebApkResponse, download_url));
 
-  WebApkInstallerRunner runner;
-  runner.Run();
-  EXPECT_FALSE(runner.success());
+  std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
+  runner->Run();
+  EXPECT_FALSE(runner->success());
 }
 
 namespace {
 
 // Returns an HttpResponse which cannot be parsed as a webapk::WebApkResponse.
 std::unique_ptr<net::test_server::HttpResponse>
 BuildUnparsableWebApkResponse() {
   std::unique_ptr<net::test_server::BasicHttpResponse> response(
       new net::test_server::BasicHttpResponse());
   response->set_code(net::HTTP_OK);
   response->set_content("😀");
   return std::move(response);
 }
 
 }  // anonymous namespace
 
 // Test that an HTTP response which cannot be parsed as a webapk::WebApkResponse
 // is handled properly.
 TEST_F(WebApkInstallerTest, UnparsableCreateWebApkResponse) {
   SetWebApkResponseBuilder(base::Bind(&BuildUnparsableWebApkResponse));
 
-  WebApkInstallerRunner runner;
-  runner.Run();
-  EXPECT_FALSE(runner.success());
+  std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
+  runner->Run();
+  EXPECT_FALSE(runner->success());
 }