src/full-codegen/x64/full-codegen-x64.cc - Issue 2231813003: Make Variable::is_this always return the correct value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove patch Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index e491e98a2635096b40ee71938d03fb4c7e122560..bc32e5ca3c1e58f4e35b3ffe8c548f8db848f9d6 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -2948,7 +2948,7 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {

Variable* var = proxy->var();

// Delete of an unqualified identifier is disallowed in strict mode but

// "delete this" is allowed.

- bool is_this = var->HasThisName(isolate());

+ bool is_this = var->is_this();

DCHECK(is_sloppy(language_mode()) || is_this);

if (var->IsUnallocatedOrGlobalSlot()) {

__ movp(rax, NativeContextOperand());