Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/ast/scopes.h

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove patch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index d71f084ddc848571ebf964bd13e255e6b8ccc278..6932e84babfe7f7e3c350f710cea82018325f044 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -522,7 +522,8 @@ class Scope: public ZoneObject {
// Create a non-local variable with a given name.
// These variables are looked up dynamically at runtime.
- Variable* NonLocal(const AstRawString* name, VariableMode mode);
+ Variable* NonLocal(const AstRawString* name, VariableMode mode,
+ Variable::Kind variable_kind);
// Variable resolution.
// Possible results of a recursive variable lookup telling if and how a
@@ -714,7 +715,8 @@ class DeclarationScope : public Scope {
// script scope. The variable was introduced (possibly from an inner
// scope) by a reference to an unresolved variable with no intervening
// with statements or eval calls.
- Variable* DeclareDynamicGlobal(const AstRawString* name);
+ Variable* DeclareDynamicGlobal(const AstRawString* name,
+ Variable::Kind variable_kind);
// The variable corresponding to the 'this' value.
Variable* receiver() {

Powered by Google App Engine
This is Rietveld 408576698