Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: src/ast/ast.h

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove patch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.h » ('j') | src/ast/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index ebb32208010177a511b6432bd23c96489e7e884e..31e3520be6046d90a026157c8d6c2fd3397946f7 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -1632,6 +1632,9 @@ class VariableProxy final : public Expression {
BailoutId BeforeId() const { return BailoutId(local_id(0)); }
void set_next_unresolved(VariableProxy* next) { next_unresolved_ = next; }
VariableProxy* next_unresolved() { return next_unresolved_; }
+ Variable::Kind var_kind() const {
+ return is_this() ? Variable::THIS : Variable::NORMAL;
adamk 2016/08/10 17:57:39 I think the reason this bugs me is that var_kind()
Toon Verwaest 2016/08/11 08:46:25 Acknowledged.
+ }
private:
friend class AstNodeFactory;
« no previous file with comments | « no previous file | src/ast/scopes.h » ('j') | src/ast/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698