Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2965 matching lines...) Expand 10 before | Expand all | Expand 10 after
2976 VisitForStackValue(property->obj()); 2976 VisitForStackValue(property->obj());
2977 VisitForStackValue(property->key()); 2977 VisitForStackValue(property->key());
2978 CallRuntimeWithOperands(is_strict(language_mode()) 2978 CallRuntimeWithOperands(is_strict(language_mode())
2979 ? Runtime::kDeleteProperty_Strict 2979 ? Runtime::kDeleteProperty_Strict
2980 : Runtime::kDeleteProperty_Sloppy); 2980 : Runtime::kDeleteProperty_Sloppy);
2981 context()->Plug(r2); 2981 context()->Plug(r2);
2982 } else if (proxy != NULL) { 2982 } else if (proxy != NULL) {
2983 Variable* var = proxy->var(); 2983 Variable* var = proxy->var();
2984 // Delete of an unqualified identifier is disallowed in strict mode but 2984 // Delete of an unqualified identifier is disallowed in strict mode but
2985 // "delete this" is allowed. 2985 // "delete this" is allowed.
2986 bool is_this = var->HasThisName(isolate()); 2986 bool is_this = var->is_this();
2987 DCHECK(is_sloppy(language_mode()) || is_this); 2987 DCHECK(is_sloppy(language_mode()) || is_this);
2988 if (var->IsUnallocatedOrGlobalSlot()) { 2988 if (var->IsUnallocatedOrGlobalSlot()) {
2989 __ LoadGlobalObject(r4); 2989 __ LoadGlobalObject(r4);
2990 __ mov(r3, Operand(var->name())); 2990 __ mov(r3, Operand(var->name()));
2991 __ Push(r4, r3); 2991 __ Push(r4, r3);
2992 __ CallRuntime(Runtime::kDeleteProperty_Sloppy); 2992 __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
2993 context()->Plug(r2); 2993 context()->Plug(r2);
2994 } else if (var->IsStackAllocated() || var->IsContextSlot()) { 2994 } else if (var->IsStackAllocated() || var->IsContextSlot()) {
2995 // Result of deleting non-global, non-dynamic variables is false. 2995 // Result of deleting non-global, non-dynamic variables is false.
2996 // The subexpression does not have side effects. 2996 // The subexpression does not have side effects.
(...skipping 676 matching lines...) Expand 10 before | Expand all | Expand 10 after
3673 DCHECK(kOSRBranchInstruction == br_instr); 3673 DCHECK(kOSRBranchInstruction == br_instr);
3674 3674
3675 DCHECK(interrupt_address == 3675 DCHECK(interrupt_address ==
3676 isolate->builtins()->OnStackReplacement()->entry()); 3676 isolate->builtins()->OnStackReplacement()->entry());
3677 return ON_STACK_REPLACEMENT; 3677 return ON_STACK_REPLACEMENT;
3678 } 3678 }
3679 3679
3680 } // namespace internal 3680 } // namespace internal
3681 } // namespace v8 3681 } // namespace v8
3682 #endif // V8_TARGET_ARCH_S390 3682 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698