Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3044 matching lines...) Expand 10 before | Expand all | Expand 10 after
3055 VisitForStackValue(property->obj()); 3055 VisitForStackValue(property->obj());
3056 VisitForStackValue(property->key()); 3056 VisitForStackValue(property->key());
3057 CallRuntimeWithOperands(is_strict(language_mode()) 3057 CallRuntimeWithOperands(is_strict(language_mode())
3058 ? Runtime::kDeleteProperty_Strict 3058 ? Runtime::kDeleteProperty_Strict
3059 : Runtime::kDeleteProperty_Sloppy); 3059 : Runtime::kDeleteProperty_Sloppy);
3060 context()->Plug(r3); 3060 context()->Plug(r3);
3061 } else if (proxy != NULL) { 3061 } else if (proxy != NULL) {
3062 Variable* var = proxy->var(); 3062 Variable* var = proxy->var();
3063 // Delete of an unqualified identifier is disallowed in strict mode but 3063 // Delete of an unqualified identifier is disallowed in strict mode but
3064 // "delete this" is allowed. 3064 // "delete this" is allowed.
3065 bool is_this = var->HasThisName(isolate()); 3065 bool is_this = var->is_this();
3066 DCHECK(is_sloppy(language_mode()) || is_this); 3066 DCHECK(is_sloppy(language_mode()) || is_this);
3067 if (var->IsUnallocatedOrGlobalSlot()) { 3067 if (var->IsUnallocatedOrGlobalSlot()) {
3068 __ LoadGlobalObject(r5); 3068 __ LoadGlobalObject(r5);
3069 __ mov(r4, Operand(var->name())); 3069 __ mov(r4, Operand(var->name()));
3070 __ Push(r5, r4); 3070 __ Push(r5, r4);
3071 __ CallRuntime(Runtime::kDeleteProperty_Sloppy); 3071 __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
3072 context()->Plug(r3); 3072 context()->Plug(r3);
3073 } else if (var->IsStackAllocated() || var->IsContextSlot()) { 3073 } else if (var->IsStackAllocated() || var->IsContextSlot()) {
3074 // Result of deleting non-global, non-dynamic variables is false. 3074 // Result of deleting non-global, non-dynamic variables is false.
3075 // The subexpression does not have side effects. 3075 // The subexpression does not have side effects.
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
3760 3760
3761 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 3761 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
3762 3762
3763 DCHECK(interrupt_address == 3763 DCHECK(interrupt_address ==
3764 isolate->builtins()->OnStackReplacement()->entry()); 3764 isolate->builtins()->OnStackReplacement()->entry());
3765 return ON_STACK_REPLACEMENT; 3765 return ON_STACK_REPLACEMENT;
3766 } 3766 }
3767 } // namespace internal 3767 } // namespace internal
3768 } // namespace v8 3768 } // namespace v8
3769 #endif // V8_TARGET_ARCH_PPC 3769 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698