Make Variable::is_this always return the correct value

src/ast/variables.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_VARIABLES_H_
 #define V8_AST_VARIABLES_H_
 
 #include "src/ast/ast-value-factory.h"
 #include "src/zone.h"
 
@@ skipping 64 matching lines @@
   bool binding_needs_init() const {
     DCHECK(initialization_flag_ != kNeedsInitialization ||
            IsLexicalVariableMode(mode_));
     return initialization_flag_ == kNeedsInitialization;
   }
 
   bool is_function() const { return kind_ == FUNCTION; }
   bool is_this() const { return kind_ == THIS; }
   bool is_arguments() const { return kind_ == ARGUMENTS; }
 
-  // For script scopes, the "this" binding is provided by a ScriptContext added
-  // to the global's ScriptContextTable.  This binding might not statically
-  // resolve to a Variable::THIS binding, instead being DYNAMIC_LOCAL.  However
-  // any variable named "this" does indeed refer to a Variable::THIS binding;
-  // the grammar ensures this to be the case.  So wherever a "this" binding
-  // might be provided by the global, use HasThisName instead of is_this().
-  bool HasThisName(Isolate* isolate,
-                   HandleDereferenceMode deref_mode =
-                       HandleDereferenceMode::kAllowed) const {
-    // Note: it is safe to dereference isolate->factory()->this_string() here
-    // regardless of |deref_mode| because it is a constant root and so will
-    // never be updated or moved.
-    return is_this() ||
-           name_is_identical_to(isolate->factory()->this_string(), deref_mode);
-  }
-
   // True if the variable is named eval and not known to be shadowed.
   bool is_possibly_eval(Isolate* isolate,
                         HandleDereferenceMode deref_mode =
                             HandleDereferenceMode::kAllowed) const {
     // Note: it is safe to dereference isolate->factory()->eval_string() here
     // regardless of |deref_mode| because it is a constant root and so will
     // never be updated or moved.
     return !is_this() &&
            name_is_identical_to(isolate->factory()->eval_string(), deref_mode);
   }
@@ skipping 52 matching lines @@
   // Usage info.
   bool force_context_allocation_;  // set by variable resolver
   bool is_used_;
   InitializationFlag initialization_flag_;
   MaybeAssignedFlag maybe_assigned_;
 };
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_AST_VARIABLES_H_