Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove patch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2982 matching lines...) Expand 10 before | Expand all | Expand 10 after
2993 VisitForStackValue(property->obj()); 2993 VisitForStackValue(property->obj());
2994 VisitForStackValue(property->key()); 2994 VisitForStackValue(property->key());
2995 CallRuntimeWithOperands(is_strict(language_mode()) 2995 CallRuntimeWithOperands(is_strict(language_mode())
2996 ? Runtime::kDeleteProperty_Strict 2996 ? Runtime::kDeleteProperty_Strict
2997 : Runtime::kDeleteProperty_Sloppy); 2997 : Runtime::kDeleteProperty_Sloppy);
2998 context()->Plug(r2); 2998 context()->Plug(r2);
2999 } else if (proxy != NULL) { 2999 } else if (proxy != NULL) {
3000 Variable* var = proxy->var(); 3000 Variable* var = proxy->var();
3001 // Delete of an unqualified identifier is disallowed in strict mode but 3001 // Delete of an unqualified identifier is disallowed in strict mode but
3002 // "delete this" is allowed. 3002 // "delete this" is allowed.
3003 bool is_this = var->HasThisName(isolate()); 3003 bool is_this = var->is_this();
3004 DCHECK(is_sloppy(language_mode()) || is_this); 3004 DCHECK(is_sloppy(language_mode()) || is_this);
3005 if (var->IsUnallocatedOrGlobalSlot()) { 3005 if (var->IsUnallocatedOrGlobalSlot()) {
3006 __ LoadGlobalObject(r4); 3006 __ LoadGlobalObject(r4);
3007 __ mov(r3, Operand(var->name())); 3007 __ mov(r3, Operand(var->name()));
3008 __ Push(r4, r3); 3008 __ Push(r4, r3);
3009 __ CallRuntime(Runtime::kDeleteProperty_Sloppy); 3009 __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
3010 context()->Plug(r2); 3010 context()->Plug(r2);
3011 } else if (var->IsStackAllocated() || var->IsContextSlot()) { 3011 } else if (var->IsStackAllocated() || var->IsContextSlot()) {
3012 // Result of deleting non-global, non-dynamic variables is false. 3012 // Result of deleting non-global, non-dynamic variables is false.
3013 // The subexpression does not have side effects. 3013 // The subexpression does not have side effects.
(...skipping 676 matching lines...) Expand 10 before | Expand all | Expand 10 after
3690 DCHECK(kOSRBranchInstruction == br_instr); 3690 DCHECK(kOSRBranchInstruction == br_instr);
3691 3691
3692 DCHECK(interrupt_address == 3692 DCHECK(interrupt_address ==
3693 isolate->builtins()->OnStackReplacement()->entry()); 3693 isolate->builtins()->OnStackReplacement()->entry());
3694 return ON_STACK_REPLACEMENT; 3694 return ON_STACK_REPLACEMENT;
3695 } 3695 }
3696 3696
3697 } // namespace internal 3697 } // namespace internal
3698 } // namespace v8 3698 } // namespace v8
3699 #endif // V8_TARGET_ARCH_S390 3699 #endif // V8_TARGET_ARCH_S390
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698