Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove patch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3062 matching lines...) Expand 10 before | Expand all | Expand 10 after
3073 VisitForStackValue(property->obj()); 3073 VisitForStackValue(property->obj());
3074 VisitForStackValue(property->key()); 3074 VisitForStackValue(property->key());
3075 CallRuntimeWithOperands(is_strict(language_mode()) 3075 CallRuntimeWithOperands(is_strict(language_mode())
3076 ? Runtime::kDeleteProperty_Strict 3076 ? Runtime::kDeleteProperty_Strict
3077 : Runtime::kDeleteProperty_Sloppy); 3077 : Runtime::kDeleteProperty_Sloppy);
3078 context()->Plug(r3); 3078 context()->Plug(r3);
3079 } else if (proxy != NULL) { 3079 } else if (proxy != NULL) {
3080 Variable* var = proxy->var(); 3080 Variable* var = proxy->var();
3081 // Delete of an unqualified identifier is disallowed in strict mode but 3081 // Delete of an unqualified identifier is disallowed in strict mode but
3082 // "delete this" is allowed. 3082 // "delete this" is allowed.
3083 bool is_this = var->HasThisName(isolate()); 3083 bool is_this = var->is_this();
3084 DCHECK(is_sloppy(language_mode()) || is_this); 3084 DCHECK(is_sloppy(language_mode()) || is_this);
3085 if (var->IsUnallocatedOrGlobalSlot()) { 3085 if (var->IsUnallocatedOrGlobalSlot()) {
3086 __ LoadGlobalObject(r5); 3086 __ LoadGlobalObject(r5);
3087 __ mov(r4, Operand(var->name())); 3087 __ mov(r4, Operand(var->name()));
3088 __ Push(r5, r4); 3088 __ Push(r5, r4);
3089 __ CallRuntime(Runtime::kDeleteProperty_Sloppy); 3089 __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
3090 context()->Plug(r3); 3090 context()->Plug(r3);
3091 } else if (var->IsStackAllocated() || var->IsContextSlot()) { 3091 } else if (var->IsStackAllocated() || var->IsContextSlot()) {
3092 // Result of deleting non-global, non-dynamic variables is false. 3092 // Result of deleting non-global, non-dynamic variables is false.
3093 // The subexpression does not have side effects. 3093 // The subexpression does not have side effects.
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
3778 3778
3779 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 3779 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
3780 3780
3781 DCHECK(interrupt_address == 3781 DCHECK(interrupt_address ==
3782 isolate->builtins()->OnStackReplacement()->entry()); 3782 isolate->builtins()->OnStackReplacement()->entry());
3783 return ON_STACK_REPLACEMENT; 3783 return ON_STACK_REPLACEMENT;
3784 } 3784 }
3785 } // namespace internal 3785 } // namespace internal
3786 } // namespace v8 3786 } // namespace v8
3787 #endif // V8_TARGET_ARCH_PPC 3787 #endif // V8_TARGET_ARCH_PPC
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698