Make Variable::is_this always return the correct value

src/ast/ast.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_AST_H_
 #define V8_AST_AST_H_
 
 #include "src/ast/ast-value-factory.h"
 #include "src/ast/modules.h"
 #include "src/ast/variables.h"
@@ skipping 1614 matching lines @@
 
   void AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
                                  FeedbackVectorSlotCache* cache);
 
   FeedbackVectorSlot VariableFeedbackSlot() { return variable_feedback_slot_; }
 
   static int num_ids() { return parent_num_ids() + 1; }
   BailoutId BeforeId() const { return BailoutId(local_id(0)); }
   void set_next_unresolved(VariableProxy* next) { next_unresolved_ = next; }
   VariableProxy* next_unresolved() { return next_unresolved_; }
+  Variable::Kind var_kind() const {
+    return is_this() ? Variable::THIS : Variable::NORMAL;

[adamk, 2016/08/10 17:57:39]

I think the reason this bugs me is that var_kind() and var()->kind() can
disagree.

[Toon Verwaest, 2016/08/11 08:46:25]

Acknowledged.

+  }
 
  private:
   friend class AstNodeFactory;
 
   VariableProxy(Zone* zone, Variable* var, int start_position,
                 int end_position);
   VariableProxy(Zone* zone, const AstRawString* name,
                 Variable::Kind variable_kind, int start_position,
                 int end_position);
   VariableProxy(Zone* zone, const VariableProxy* copy_from);
@@ skipping 1832 matching lines @@
                                     : NULL;                                   \
   }
 AST_NODE_LIST(DECLARE_NODE_FUNCTIONS)
 #undef DECLARE_NODE_FUNCTIONS
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_AST_AST_H_