Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2231813002: Revert of Adds support for running unittests using XCTest on iOS. (Closed)

Created:
4 years, 4 months ago by Olivier
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds support for running unittests using XCTest on iOS. (patchset #2 id:20001 of https://codereview.chromium.org/2226623003/ ) Reason for revert: frezes unittests on ios bots. Original issue's description: > Adds support for running unittests using XCTest on iOS. > > Modifies the base TestSuite to check if running under XCTest and return early > without running tests if so. This allows XCTest to drive running the individual > tests, while still allowing the TestSuite to perform setup tasks. > > BUG=635509 > > Committed: https://crrev.com/fc9315e90cf523b90010145980f953f86c077a51 > Cr-Commit-Position: refs/heads/master@{#410698} TBR=phajdan.jr@chromium.org,mark@chromium.org,rohitrao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635509 Committed: https://crrev.com/e32d99be07ac02f74efaa502c18a7b3f7a550788 Cr-Commit-Position: refs/heads/master@{#411028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M base/test/test_suite.cc View 1 chunk +1 line, -7 lines 0 comments Download
M base/test/test_support_ios.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/test/test_support_ios.mm View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Olivier
Created Revert of Adds support for running unittests using XCTest on iOS.
4 years, 4 months ago (2016-08-10 12:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231813002/1
4 years, 4 months ago (2016-08-10 12:49:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 12:50:12 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 12:52:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e32d99be07ac02f74efaa502c18a7b3f7a550788
Cr-Commit-Position: refs/heads/master@{#411028}

Powered by Google App Engine
This is Rietveld 408576698