Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2231803003: Install downloaded WebAPK when "installation from unknown sources" is enabled (Closed)

Created:
4 years, 4 months ago by pkotwicz
Modified:
4 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, dominickn+watch_chromium.org, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Install downloaded WebAPK when "installation from unknown sources" is enabled BUG=635373 Committed: https://crrev.com/74d273a69f5e0954c0aa84a82fa5dfc55c3754d4 Cr-Commit-Position: refs/heads/master@{#411128}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into webapk_install #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 1 2 chunks +40 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
Yaron, can you please take a look? I don't think that Chrome should encourage the ...
4 years, 4 months ago (2016-08-10 17:27:31 UTC) #2
Yaron
On 2016/08/10 17:27:31, pkotwicz wrote: > Yaron, can you please take a look? > > ...
4 years, 4 months ago (2016-08-10 17:37:35 UTC) #4
pkotwicz
Yaron, can you please take another look? - We discussed offline and decided to keep ...
4 years, 4 months ago (2016-08-10 18:07:04 UTC) #5
Yaron
lgtm
4 years, 4 months ago (2016-08-10 18:09:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231803003/20001
4 years, 4 months ago (2016-08-10 19:04:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 20:14:14 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 20:16:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74d273a69f5e0954c0aa84a82fa5dfc55c3754d4
Cr-Commit-Position: refs/heads/master@{#411128}

Powered by Google App Engine
This is Rietveld 408576698