Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2231693002: Revert of Added tombstones in instrumentation tests results. (Closed)

Created:
4 years, 4 months ago by kjellander_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added tombstones in instrumentation tests results. (patchset #11 id:200001 of https://codereview.chromium.org/2201833002/ ) Reason for revert: This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android, like this: W 0.547s Main No tombstones. Traceback (most recent call last): File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 304, in <module> sys.exit(main()) File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 300, in main W 0.547s Main No tombstones to resolve. for line in resolved_tombstones: TypeError: 'NoneType' object is not iterable Please make sure to have proper tests in place before relanding. Original issue's description: > Added tombstones in instrumentation tests results. > > If an instrumentation test crashes, the cl will grab the tombstones and > add the tombstones as a part of the result. > > BUG=631213 > > Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8 > Cr-Commit-Position: refs/heads/master@{#410929} TBR=mikecase@chromium.org,jbudorick@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631213 Committed: https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26 Cr-Commit-Position: refs/heads/master@{#410977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -77 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +0 lines, -10 lines 0 comments Download
M build/android/pylib/instrumentation/test_result.py View 1 chunk +0 lines, -4 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +1 line, -12 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/tombstones.py View 5 chunks +14 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_chromium
Created Revert of Added tombstones in instrumentation tests results.
4 years, 4 months ago (2016-08-10 06:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231693002/1
4 years, 4 months ago (2016-08-10 06:11:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 06:12:37 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:15:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26
Cr-Commit-Position: refs/heads/master@{#410977}

Powered by Google App Engine
This is Rietveld 408576698