Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2231663002: Fix SkDEBUGCODE to accept commas (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M include/core/SkTypes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkDConicLineIntersection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
csmartdalton
4 years, 4 months ago (2016-08-10 03:37:46 UTC) #3
caryclark
lgtm
4 years, 4 months ago (2016-08-10 12:27:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231663002/1
4 years, 4 months ago (2016-08-10 15:36:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12399)
4 years, 4 months ago (2016-08-10 15:37:59 UTC) #8
bsalomon
lgtm
4 years, 4 months ago (2016-08-10 17:05:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231663002/1
4 years, 4 months ago (2016-08-10 17:05:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231663002/1
4 years, 4 months ago (2016-08-10 17:06:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231663002/1
4 years, 4 months ago (2016-08-10 17:07:05 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:08:02 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ceeaa78713dde9cc6e3ccd688aca6021b260af4d

Powered by Google App Engine
This is Rietveld 408576698