Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2231653003: Revert of [debugger] reapply break points after clearing one shots. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] reapply break points after clearing one shots. (patchset #1 id:1 of https://codereview.chromium.org/2221333002/ ) Reason for revert: Found better solution. Original issue's description: > [debugger] reapply break points after clearing one shots. > > On the debug info, we have a list of existing break points. When we > step in the debugger, we flood the function with one-shot break points. > Afterwards, we clear these one-shots by clearing all break locations. > > Previously, while clearing break locations, we would skip ones that have > actual break points. Now we clear all break locations, and then reapply > break points. This is necessary for the next step, when we encode break > point info by source position, and not code offset. Encoding by code > offset would mean that break points are dependent on the code kind we > use. > > R=jgruber@chromium.org > BUG=v8:5265 > > Committed: https://crrev.com/808981a22ee19461bbe981ab33b58792d991533e > Cr-Commit-Position: refs/heads/master@{#38492} TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5265 Committed: https://crrev.com/56b7a5fa68cfc8d4a54185e1c74dfaf42c30e4a4 Cr-Commit-Position: refs/heads/master@{#38521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M src/debug/debug.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug/debug.cc View 3 chunks +7 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [debugger] reapply break points after clearing one shots.
4 years, 4 months ago (2016-08-10 08:22:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231653003/1
4 years, 4 months ago (2016-08-10 08:22:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 08:22:36 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 08:23:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56b7a5fa68cfc8d4a54185e1c74dfaf42c30e4a4
Cr-Commit-Position: refs/heads/master@{#38521}

Powered by Google App Engine
This is Rietveld 408576698