Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 2231643002: Fix v8_current_cpu setting for CrOS builds after r410853. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
stevenjb, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix v8_current_cpu setting for CrOS builds after r410853. In r410853 we changed how the GN toolchains move arguments around, but we missed one reference to the v8_toolchain_cpu in the CrOS toolchain definitions. This CL fixes that. TBR=brettw@chromium.org, stevenjb@chromium.org BUG=634446 Committed: https://crrev.com/72d6d06aef7e5284e20e30c685ec35557d9e38a7 Cr-Commit-Position: refs/heads/master@{#410933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/cros/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 4 months ago (2016-08-10 01:53:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231643002/1
4 years, 4 months ago (2016-08-10 01:53:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 03:02:55 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72d6d06aef7e5284e20e30c685ec35557d9e38a7 Cr-Commit-Position: refs/heads/master@{#410933}
4 years, 4 months ago (2016-08-10 03:04:39 UTC) #6
brettw
4 years, 4 months ago (2016-08-10 03:53:06 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698