Chromium Code Reviews

Issue 223163004: Oilpan: Fix tracing of events through XMLHttpRequestProgressEventThrottle. (Closed)

Created:
6 years, 8 months ago by Mads Ager (chromium)
Modified:
6 years, 8 months ago
Reviewers:
haraken, oilpan-reviews, zerny-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Fix tracing of events through XMLHttpRequestProgressEventThrottle. This was found with the clang Blink GC plugin. Let's all turn it on and keep it running! :) R=haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170754

Patch Set 1 #

Patch Set 2 : Add init for RawPtr in HTMLFormElement. #

Unified diffs Side-by-side diffs Stats (+13 lines, -3 lines)
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -0 lines 0 comments
M Source/core/xml/XMLHttpRequestProgressEventThrottle.h View 3 chunks +5 lines, -2 lines 0 comments
M Source/core/xml/XMLHttpRequestProgressEventThrottle.cpp View 1 chunk +6 lines, -0 lines 0 comments

Messages

Total messages: 6 (0 generated)
Mads Ager (chromium)
6 years, 8 months ago (2014-04-03 06:54:44 UTC) #1
zerny-chromium
lgtm
6 years, 8 months ago (2014-04-03 06:57:20 UTC) #2
haraken
LGTM. Sorry about not running the plugin. I'll turn it on.
6 years, 8 months ago (2014-04-03 06:57:21 UTC) #3
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 8 months ago (2014-04-03 07:00:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/223163004/20001
6 years, 8 months ago (2014-04-03 07:00:24 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 08:05:38 UTC) #6
Message was sent while issue was closed.
Change committed as 170754

Powered by Google App Engine