Issue 223163004: Oilpan: Fix tracing of events through XMLHttpRequestProgressEventThrottle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223163004: Oilpan: Fix tracing of events through XMLHttpRequestProgressEventThrottle. (Closed)

Created:
6 years, 8 months ago by Mads Ager (chromium)

Modified:
6 years, 8 months ago

Reviewers:
haraken, oilpan-reviews, zerny-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Oilpan: Fix tracing of events through XMLHttpRequestProgressEventThrottle. This was found with the clang Blink GC plugin. Let's all turn it on and keep it running! :) R=haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170754

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
M	Source/core/html/HTMLFormElement.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLHttpRequest.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequestProgressEventThrottle.h	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequestProgressEventThrottle.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

haraken

LGTM. Sorry about not running the plugin. I'll turn it on.

6 years, 8 months ago (2014-04-03 06:57:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/223163004/20001

6 years, 8 months ago (2014-04-03 07:00:24 UTC) #5

Message was sent while issue was closed.

Change committed as 170754