Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2231623002: Prevent integer overflow in ComputedStyle::outlineOutsetExtent. (Closed)

Created:
4 years, 4 months ago by Bugs Nash
Modified:
4 years, 4 months ago
Reviewers:
dstockwell, nainar
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent integer overflow in ComputedStyle::outlineOutsetExtent. Uses SaturatedArithmetic::saturatedAddition to prevent overflow. BUG=630524 Committed: https://crrev.com/063e851233a382696bf37ed989e322d3eced1efc Cr-Commit-Position: refs/heads/master@{#410968}

Patch Set 1 #

Patch Set 2 : Added layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/outline-offset-large.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/outline-offset-large-expected.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Bugs Nash
4 years, 4 months ago (2016-08-10 02:08:52 UTC) #2
nainar
lgtm
4 years, 4 months ago (2016-08-10 03:24:22 UTC) #3
Bugs Nash
4 years, 4 months ago (2016-08-10 03:27:26 UTC) #5
dstockwell
lgtm
4 years, 4 months ago (2016-08-10 03:52:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231623002/20001
4 years, 4 months ago (2016-08-10 04:16:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 05:41:23 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 05:44:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/063e851233a382696bf37ed989e322d3eced1efc
Cr-Commit-Position: refs/heads/master@{#410968}

Powered by Google App Engine
This is Rietveld 408576698