ui/webui/resources/cr_elements/shared_vars_css.html - Issue 2231593003: Add [hidden] rule to cr-elements :root stylesheet

Side by Side Diff: ui/webui/resources/cr_elements/shared_vars_css.html

Issue 2231593003: Add [hidden] rule to cr-elements :root stylesheet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">	1 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">

2	2

3 <!-- Common css variables for Material Design WebUI. -->	3 <!-- Common css variables for Material Design WebUI. -->

4 <style is="custom-style">	4 <style is="custom-style">

5 :root {	5 :root {

6 --cr-actionable: {	6 --cr-actionable: {

7 cursor: pointer;	7 cursor: pointer;

8 };	8 };

9 --cr-focused-item-color: var(--google-grey-300);	9 --cr-focused-item-color: var(--google-grey-300);

10 --cr-separator-line: 1px solid rgba(0, 0, 0, 0.06);	10 --cr-separator-line: 1px solid rgba(0, 0, 0, 0.06);

11 }	11 }

	12

	13 /*

	14 * Because everyone assumes [hidden] overrides {display: foo}.

	15 * TODO(michaelpg): Rename to shared_global_css.html and import only from

	16 * entry points (md_foo.html and tests). Eventually find alternative solution

	17 * to this deprecated /deep/ selector (crbug.com/498405).

	18 */
	Dan Beam 2016/08/10 16:16:36 nit: /* Everybody seems to love useless lines. * nit: /* Everybody seems to love useless lines. * They make comments so spacious. / ^ ^^ michaelpg* 2016/08/10 16:27:56 okay, that's our CSS style, but i have no love for Show quoted text On 2016/08/10 16:16:36, Dan Beam wrote: > nit: > > /* Everybody seems to love useless lines. > * They make comments so spacious. / > ^ ^^ okay, that's our CSS style, but i have no love for useless lines... it's just how we do multiline comments everywhere else. Dan Beam* 2016/08/10 16:29:24 no, it's not. if you show me all the other places Show quoted text On 2016/08/10 16:27:56, michaelpg wrote: > On 2016/08/10 16:16:36, Dan Beam wrote: > > nit: > > > > /* Everybody seems to love useless lines. > > * They make comments so spacious. */ > > ^ ^^ > > okay, that's our CSS style, but i have no love for useless lines... it's just > how we do multiline comments everywhere else. no, it's not. if you show me all the other places we do this, I'll gladly clean them up for you to fix your (and probably others') incorrect interpretation.
	19 :root /deep/ [hidden] {
	Dan Beam 2016/08/10 16:16:36 why do we need the /deep/ though? also, why is th why do we need the /deep/ though? also, why is this in a _vars_ file? michaelpg 2016/08/10 16:27:56 see description Show quoted text On 2016/08/10 16:16:36, Dan Beam wrote: > why do we need the /deep/ though? see description Show quoted text > > also, why is this in a _vars_ file? see TODO (rationale: this file sets :root styles, not solely variables, it should be renamed as such) dschuyler 2016/08/10 18:58:26 It was named root and got renamed to vars. Please Show quoted text On 2016/08/10 16:27:56, michaelpg wrote: > On 2016/08/10 16:16:36, Dan Beam wrote: > > why do we need the /deep/ though? > > see description > > > > > also, why is this in a _vars_ file? > > see TODO (rationale: this file sets :root styles, not solely variables, it > should be renamed as such) It was named root and got renamed to vars. Please see Stevenjb@ before changing it. The name was changed because the intent of the file was to contain only vars (so he/we felt that root was no longer the best name for it). How about moving this to the settings.html file?
	20 display: none !important;

	21 }

12 </style>	22 </style>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »