Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2231543002: Fix CPU type for Android x64 build. (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CPU type for Android x64 build. The string "x86_64" does not reference a CPU type in GN. Committed: https://crrev.com/7aabe8fe957b5628348db49e488a4cda1bdf7541 Cr-Commit-Position: refs/heads/master@{#410801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
brettw
4 years, 4 months ago (2016-08-09 19:24:55 UTC) #3
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-09 19:25:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231543002/1
4 years, 4 months ago (2016-08-09 19:27:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:36:32 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:38:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7aabe8fe957b5628348db49e488a4cda1bdf7541
Cr-Commit-Position: refs/heads/master@{#410801}

Powered by Google App Engine
This is Rietveld 408576698