third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp - Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed webkit_unit_tests. Fixed most layout tests, rebaselineing rest. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('K') | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

index 136068acae4cf0db9790acfa6c5c396a022162f9..79a9c03ff301c5a15706e39f3ffd960e561d5f94 100644

--- a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

@@ -86,7 +86,7 @@ protected:

WebElement webElement = mainFrame()->document().querySelector("img");

ASSERT_TRUE(isHTMLImageElement(webElement));

HTMLImageElement* imageElement = toHTMLImageElement(webElement);

- EXPECT_EQ(loaded, !!imageElement->cachedImage());

+ EXPECT_EQ(loaded, !!imageElement->naturalWidth());

}

const std::string& baseURL() const { return m_baseURL; }