Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed webkit_unit_tests. Fixed most layout tests, rebaselineing rest. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index 579a3667325526cc532e4db23babe049d21f3385..c34d45fe3194eba5dcf8ff78a81cdcdd6164d8bc 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -638,7 +638,7 @@ void Resource::didAddClient(ResourceClient* c)
}
}
-static bool shouldSendCachedDataSynchronouslyForType(Resource::Type type)
+static bool typeNeedsSynchronousCacheHit(Resource::Type type)
{
// Some resources types default to return data synchronously.
// For most of these, it's because there are layout tests that
@@ -688,8 +688,8 @@ void Resource::addClient(ResourceClient* client, PreloadReferencePolicy policy)
return;
}
- // If we have existing data to send to the new client and the resource type supprts it, send it asynchronously.
- if (!m_response.isNull() && !shouldSendCachedDataSynchronouslyForType(getType()) && !m_needsSynchronousCacheHit) {
+ // If an error has occurred or we have existing data to send to the new client and the resource type supprts it, send it asynchronously.
+ if ((errorOccurred() || !m_response.isNull()) && !typeNeedsSynchronousCacheHit(getType()) && !m_needsSynchronousCacheHit) {
m_clientsAwaitingCallback.add(client);
ResourceCallback::callbackHandler().schedule(this);
return;

Powered by Google App Engine
This is Rietveld 408576698