third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js - Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, resolve comment rewrap conflicts. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-async-post-xhr-blocked-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js b/third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js

index 883c02f31d345daf8e499848bcb6a049db00fe81..24785f7acb9bcbdb7a705178d4a89a3e9175d320 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js

+++ b/third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js

@@ -10,7 +10,7 @@ function didImageLoad()

var result = document.getElementById("result");

var myImg = document.getElementById("myImg");

- if (myImg.height == 0 && myImg.width == 0) {

+ if (myImg.naturalHeight == 0 && myImg.naturalWidth == 0) {

result.innerHTML = "Image NOT loaded.";

} else {

result.innerHTML = "Image loaded.";