third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment phrasing. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('K') | « third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index b194b12acc238adb096946b664ad9b1ea0dbd8bc..00af5d10fc8b73209e7dada5d5df142d666f72b0 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -6892,7 +6892,10 @@ TEST_P(ParameterizedWebFrameTest, ManifestCSPFetchSelf)

Resource* resource = fetchManifest(document, toKURL(m_notBaseURL + "link-manifest-fetch.json"));

- EXPECT_EQ(0, resource); // Fetching resource wasn't allowed.

+ // Fetching resource wasn't allowed.

+ ASSERT_TRUE(resource);

+ EXPECT_TRUE(resource->errorOccurred());

+ EXPECT_TRUE(resource->resourceError().isAccessCheck());

}

TEST_P(ParameterizedWebFrameTest, ManifestCSPFetchSelfReportOnly)

« third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('K') | « third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp ('k') | no next file » | no next file with comments »